Skip to content

fix: drop misleading extensions json tag on ProblemDetails - #25

Merged
rluders merged 3 commits into
mainfrom
claude/magical-clarke-txavzp
Oct 23, 2026
Merged

rluders merged 3 commits into
mainfrom
claude/magical-clarke-txavzp

Conversation

@rluders

@rluders rluders commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Closes #19

  • ProblemDetails.Extensions tag json:"extensions,omitempty" → json:"-", with a comment explaining that MarshalJSON/UnmarshalJSON flatten members to the top level.
  • Test asserting no nested extensions key is emitted.

No wire-format change.


Generated by Claude Code

MarshalJSON/UnmarshalJSON flatten extension members to the top level,
so the nested "extensions" tag was never used.

Closes #19

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FHBdej3KvFACHzafbEhw7C
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2a55b10f-24a5-4345-8973-83de8f12b362
📥 Commits

Reviewing files that changed from the base of the PR and between 84bb764 and 382412c.

📒 Files selected for processing: 2
  • problem_details.go
  • problem_details_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.27%. Comparing base (84bb764) to head (382412c).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          14       14           
  Lines         583      583           
=======================================
  Hits          503      503           
  Misses         62       62           
  Partials       18       18           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rluders
rluders merged commit 8afdf5a into main Oct 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProblemDetails.Extensions json tag is dead code (MarshalJSON never uses it)

3 participants