fix: report plugin coverage instead of the tests module - #171
Merged
Conversation
The e2e step ran -coverpkg=./... from inside tests/, so it only ever instrumented the tests module and the upload filter then dropped every line. The codecov job also had no checkout and pulled artifacts without a name, so the *.out glob matched nothing. Scope coverpkg to the plugin module, check the repo out before uploading, strip the module prefix with awk like jobs does, and fail the job when the merged summary holds no plugin blocks.
Copilot stopped reviewing on behalf of
rustatian due to an error
August 17, 2026 15:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
===========================================
+ Coverage 0 69.69% +69.69%
===========================================
Files 0 1 +1
Lines 0 66 +66
===========================================
+ Hits 0 46 +46
- Misses 0 13 +13
- Partials 0 7 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage has been reporting 0% while the suite has ~600 lines of tests. Three separate defects:
-coverpkg=./...from insidetests/, so it instrumented the tests module, not the pluginactions/checkout, so codecov could not map the reported paths onto repo filesdownload-artifactwas called with noname/pattern, which puts each artifact in its own directory, so the*.outglob matched nothingThe last green run on master uploaded 341 bytes. Locally the corrected profile carries 44 blocks.
Scopes coverpkg to
github.com/roadrunner-server/headers/v6/..., adds the checkout, downloads with an explicit pattern and path, and replaces thesedfilter with the awk prefix strip that jobs uses. Adds a guard that fails the job when the merged summary holds fewer than 10 blocks — tokenless uploads fail open, which is why this went unnoticed.Also drops
-failfast, which hides every failure after the first.