fix: measure plugin coverage in CI - #19
Merged
Merged
Conversation
The test step ran bare `go test` from tests/ with no -coverpkg, so the profile never recorded plugin packages and the sed filter left the module prefix in place on what did survive. Scope coverpkg to the plugin module, run the root unit tests, strip the prefix with awk, and fail the job when the summary holds no plugin blocks.
Copilot stopped reviewing on behalf of
rustatian due to an error
August 17, 2026 15:13
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
===========================================
+ Coverage 0 70.37% +70.37%
===========================================
Files 0 3 +3
Lines 0 108 +108
===========================================
+ Hits 0 76 +76
- Misses 0 19 +19
- Partials 0 13 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage has been reporting 0% while the suite has ~480 lines of tests.
The test step ran a bare
go testfromtests/with no-coverpkg, so the profile recorded nothing from the plugin. The transform step usedsed '2,${/roadrunner/!d}', which filters lines but never strips the module prefix, so anything that did survive stayed unmappable.config_test.goin the root module also never ran in CI.Scopes coverpkg to
github.com/roadrunner-server/protoreg/v6/..., runs./...rather than the bare package, adds a root unit step, and replaces thesedwith the awk prefix strip that jobs uses. Locally the corrected e2e profile carries 68 blocks at 77.7%. Adds a guard that fails the job when the summary holds fewer than 10 blocks — tokenless uploads fail open, which is why this went unnoticed.Also drops
-failfast.