Skip to content

[wpilibc] Fix LED crash related to the GIL #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
virtuald merged 4 commits into from
Jun 7, 2026
Merged

[wpilibc] Fix LED crash related to the GIL #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef7a7e6
[wpilibc] Fix LED crash related to the GIL
pjreiniger Jun 7, 2026
035d91f
Remove unused cpp_code
pjreiniger Jun 7, 2026
2c369dd
Re-add the overload to avoid copies
pjreiniger Jun 7, 2026
b417fac
Release gil
pjreiniger Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions subprojects/robotpy-wpilib/semiwrap/AddressableLED.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,18 @@ classes:
overloads:
std::span<const LEDData>:
std::initializer_list<LEDData>:
cpp_code: |
[](wpi::AddressableLED& self, const wpi::AddressableLEDBuffer& data) {
return self.SetData(data);
}, py::prepend()
ignore: true
Comment thread
pjreiniger marked this conversation as resolved.
Comment thread
virtuald marked this conversation as resolved.
SetColorOrder:
GetChannel:
SetStart:
GetStart:
SetGlobalData:
enums:
ColorOrder:
inline_code: |
.def("setData", [](wpi::AddressableLED& self, const wpi::AddressableLEDBuffer& data) {
return self.SetData(data);
}, release_gil(), py::prepend());
wpi::AddressableLED::LEDData:
force_no_trampoline: true
ignored_bases:
Expand Down
1 change: 1 addition & 0 deletions subprojects/robotpy-wpilib/semiwrap/AddressableLEDBuffer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ classes:
ignore: true
CreateView:
rename: __getitem__
no_release_gil: true
keepalive:
- [0, 1]
inline_code: |
Expand Down
Loading