Repository navigation
deps: update konture to 1.0.2, move rules to the 1.x filter names - #65
Merged
Merged
Conversation
Konture 1.0.2 removed the deprecated file-filter names the architecture rules were written against, so the bump alone fails to compile: notResideInAPackage -> notInPackage notHaveName -> notNamed haveName -> named No rule changes meaning. Signed-off-by: Raman Gupta <rocketraman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps konture 0.8.1 → 1.0.2 and renames the four call sites in
ArchitectureTest.ktthat used file-filter names 1.0.2 removed:notResideInAPackagenotInPackagenotHaveNamenotNamedhaveNamenamedWhy
Renovate's bump (#55) fails to compile on its own: 1.0.2 dropped the deprecated names (baole/konture#113). It passed on 1.0.1, where they were still present as deprecated aliases.
Verification
:konture-test:teston 1.0.2: 10 tests, 0 failures (counted from the result XML).AppState.ktfrom its allowlist fails "only the state layer reaches the git runner"; removingActions.ktfails "process spawning is confined to Git and the three non-git callers".Notes for the reviewer
Theme.ktis still on the process-spawning allowlist (line 268) but no longer referencesProcessBuilder, so that entry is stale.