refactor: resolve open Sonar maintainability issues - #178
Merged
Conversation
SonarQube Cloud successThe SonarQube Cloud Quality Gate passed for this PR. Quality Gate status: OK
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b30327d9fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the open Sonar maintainability findings without changing public API or runtime behavior. The changes reduce cognitive complexity by extracting focused private helpers and remove inner-member shadowing by renaming internal members to names that describe their local responsibility.
Changes
Issues resolved
Closes #154
Closes #155
Closes #156
Closes #157
Closes #158
Closes #159
Closes #160
Closes #161
Closes #162
Closes #163
Closes #164
Closes #165
Closes #166
Closes #167
Closes #168
Closes #169
Closes #170
Closes #171
Closes #172
Closes #173
Closes #174
Closes #175
Closes #176
Closes #177
Validation
dotnet restore .\Dapper.FluentMap.slnpasseddotnet build .\Dapper.FluentMap.sln --configuration Release --no-restorepassed with 0 warnings and 0 errorsdotnet test .\Dapper.FluentMap.sln --configuration Release --no-buildpassed: 477 total, 463 passed, 14 skipped, 0 failed.\eng\validate-slnx-equivalence.ps1passed: 14 projects matcheddotnet pack .\Dapper.FluentMap.slnx --configuration Release --no-build --output artifacts\validation-open-sonar-issues\packagespassed: 5.nupkgand 3.snupkgpackages created for3.0.0-dev.\eng\validate-package-metadata.ps1 -PackageDirectory artifacts\validation-open-sonar-issues\packagespassed.\eng\validate-release-artifacts.ps1 -PackageDirectory artifacts\validation-open-sonar-issues\packages -Version 3.0.0-dev -Repository rodri-oliveira-dev/Dapper-FluentMap -RepositoryUrl https://github.com/rodri-oliveira-dev/Dapper-FluentMap -Commit <HEAD> -Branch refs/heads/fix/resolve-open-sonar-issues -ManifestPath artifacts\validation-open-sonar-issues\release-metadata\artifact-manifest.jsonpassedgit diff --check master...HEADpasseddotnet format .\Dapper.FluentMap.sln --verify-no-changes --verbosity minimalwas run and failed on existing repository-wide whitespace/charset/import ordering issues, including many files outside this change; no formatter rewrites were applied.Compatibility
No public API changes were introduced. Observable runtime behavior and analyzer/generator diagnostic IDs/messages are intended to be preserved; the changes are private/internal refactorings and internal member renames only.