Fix MSVC math library link#33
Open
rodrigomatta wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the MSVC Windows CMake issue where
ggml-basecould receiveMATH_LIBRARY-NOTFOUND.libas a linker dependency.On MSVC, math functions are provided by the Visual Studio CRT, so there is no separate
libm/mlibrary to link. The top-level CMake now setsMATH_LIBRARYto an emptycache value for MSVC before loading
ggml, preventingMATH_LIBRARY-NOTFOUNDfrom propagating into generated Visual Studio projects.This PR also brings
stagingup to date withmain.Verification
cmake -S . -B build-cpu -DCMAKE_BUILD_TYPE=Release -DS2_AUTO_APPLY_LOCAL_PATCHES=ON -DS2_VULKAN=OFFcmake --build build-cpu --config Releasecmake -S . -B build-vulkan -DCMAKE_BUILD_TYPE=Release -DS2_AUTO_APPLY_LOCAL_PATCHES=ON -DS2_VULKAN=ONcmake --build build-vulkan --config Releases2 --helpMATH_LIBRARY-NOTFOUND/NOTFOUND.libentries inbuild-cpuorbuild-vulkan