Skip to content

ci: retire push/PR triggers to workflow_dispatch (local-builds quota policy) - #1118

Closed
wrightpt wants to merge 37 commits into
rohitg00:mainfrom
wrightpt:agent/retire-gh-push-triggers
Closed

ci: retire push/PR triggers to workflow_dispatch (local-builds quota policy)#1118
wrightpt wants to merge 37 commits into
rohitg00:mainfrom
wrightpt:agent/retire-gh-push-triggers

Conversation

@wrightpt

@wrightpt wrightpt commented Jul 28, 2026

Copy link
Copy Markdown

What

Trigger-only change: removes the push: and pull_request: trigger blocks from .github/workflows/ci.yml, keeping workflow_dispatch:. No job, step, matrix, or concurrency changes; both workflow files still parse as valid YAML.

Fleet policy: the GitHub account has a 2,000-minute/month Actions quota with a $0 stop-usage budget (reference: trading-system/docs/LOCAL_IMAGE_BUILDS.md). Push/PR-triggered workflows are being retired to manual runs; this repo's AGENTS.md already requires npm test locally before PR.

Per-workflow decisions

Workflow Decision Reason
ci.yml CONVERT Had push + pull_request triggers on main; no repo doc declares it a keeper. Recent runs show action_required (quota-blocked), and the file's own header already documented workflow_dispatch as the manual re-run path.
publish.yml KEEP (unchanged) No push/PR triggers — release: [published] + workflow_dispatch only; out of scope. The release trigger is the documented npm-publish mechanism in CONTRIBUTING.md and runs only on tagged releases.

Manual runs remain available via the Actions tab ("Run workflow"). Do not merge without review.

Summary by CodeRabbit

  • New Features

    • Added Actions v2 with lifecycle, approvals, dependencies, readiness views, pagination, migration, export/import, and cleanup support.
    • Added Streamable HTTP MCP access with authentication and origin controls.
    • Added paginated, filterable session listings and session-context updates.
    • Added durable asynchronous observation processing with receipts, retries, and deduplication.
    • Added configurable tool visibility and LLM execution controls.
  • Bug Fixes

    • Improved action readiness updates, concurrency handling, metrics for skipped operations, and duplicate worker prevention.
  • Documentation

    • Updated MCP tool references, configuration guidance, API documentation, and tool counts.

wrightpt added 30 commits July 9, 2026 23:28
…tion

Merge workstation AgentMemory hardening stack
Add canonical AgentMemory project scope
Decouple hook capture from synchronous observe
Await asynchronous hook transport acknowledgements
Make observation ingestion durable and report disabled LLM work as skipped
Build runtime assets automatically before npm packaging.
Prevent duplicate workers from unregistering live AgentMemory routes.
Add resilient Streamable HTTP MCP transport
Exclude blocked actions from AgentMemory frontier
wrightpt added 7 commits July 17, 2026 08:06
feat: add Actions v2 schema and safe migration
…eKV boundary

The iii-engine resolves state::get with undefined for missing keys, not
null. rebaseActionMutation's create path compares expectedBefore === null
against current with strict equality, so every mem::action-create threw
action_revision_conflict while updates kept working. The in-memory test
mock coerced with ?? null and hid the real engine semantics; add an
engine-faithful regression test (test/state-kv.test.ts).
state::get resolves undefined for missing keys; StateKV.get is the
normalizing boundary (2026-07-17 action_revision_conflict outage).
Also documents the symlinked global install so deploys are build +
service restart.
Bounds action-store growth (the 15-min write-path canary alone adds
~96 cancelled actions/day). mem::action-gc collects done/cancelled
actions older than maxAgeDays (default 30) that appear in no edge,
dry-run by default, revalidating each candidate before deletion and
emitting one batched action_delete audit row. Exposed as
POST /agentmemory/actions/gc (REST 131).
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

@wrightpt is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@wrightpt

Copy link
Copy Markdown
Author

Opened against the wrong base repo (meant for the wrightpt fork). Closing unmerged; correct PR follows on wrightpt/agentmemory. Sorry for the noise.

@wrightpt wrightpt closed this Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dbb8aff2-5297-4eb4-90ef-6888a3aa1e8f

📥 Commits

Reviewing files that changed from the base of the PR and between d8b5267 and 4fd62a0.

⛔ Files ignored due to path filters (2)
  • assets/tags/light/stat-tools.svg is excluded by !**/*.svg
  • assets/tags/stat-tools.svg is excluded by !**/*.svg
📒 Files selected for processing (122)
  • .agentmemory/project.json
  • .env.example
  • .github/workflows/ci.yml
  • AGENTS.md
  • INSTALL_FOR_AGENTS.md
  • README.md
  • docs/superpowers/specs/2026-07-17-actions-v2-design.md
  • iii-config.docker.yaml
  • iii-config.yaml
  • package.json
  • packages/mcp/README.md
  • packages/mcp/bin.mjs
  • plugin/.claude-plugin/plugin.json
  • plugin/.codex-plugin/plugin.json
  • plugin/opencode/README.md
  • plugin/plugin.json
  • plugin/scripts/notification.mjs
  • plugin/scripts/post-commit.mjs
  • plugin/scripts/post-tool-failure.mjs
  • plugin/scripts/post-tool-use.mjs
  • plugin/scripts/pre-compact.mjs
  • plugin/scripts/pre-tool-use.mjs
  • plugin/scripts/prompt-submit.mjs
  • plugin/scripts/session-end.mjs
  • plugin/scripts/session-start.mjs
  • plugin/scripts/stop.mjs
  • plugin/scripts/subagent-start.mjs
  • plugin/scripts/subagent-stop.mjs
  • plugin/scripts/task-completed.mjs
  • plugin/skills/agentmemory-config/REFERENCE.md
  • plugin/skills/agentmemory-mcp-tools/REFERENCE.md
  • plugin/skills/agentmemory-rest-api/REFERENCE.md
  • src/cli.ts
  • src/config.ts
  • src/eval/metrics-store.ts
  • src/functions/action-model.ts
  • src/functions/action-query.ts
  • src/functions/action-readiness-refresh.ts
  • src/functions/action-store.ts
  • src/functions/actions-v2-migration.ts
  • src/functions/actions.ts
  • src/functions/checkpoints.ts
  • src/functions/compress.ts
  • src/functions/crystallize.ts
  • src/functions/diagnostics.ts
  • src/functions/disk-size-manager.ts
  • src/functions/export-import.ts
  • src/functions/frontier.ts
  • src/functions/image-quota-cleanup.ts
  • src/functions/image-refs.ts
  • src/functions/leases.ts
  • src/functions/mesh.ts
  • src/functions/migrate.ts
  • src/functions/observe.ts
  • src/functions/remember.ts
  • src/functions/routines.ts
  • src/functions/sentinels.ts
  • src/functions/session-context.ts
  • src/functions/session-list.ts
  • src/functions/sketches.ts
  • src/functions/summarize.ts
  • src/hooks/_observe.ts
  • src/hooks/_project.ts
  • src/hooks/notification.ts
  • src/hooks/post-tool-failure.ts
  • src/hooks/post-tool-use.ts
  • src/hooks/prompt-submit.ts
  • src/hooks/session-start.ts
  • src/hooks/subagent-start.ts
  • src/hooks/subagent-stop.ts
  • src/hooks/task-completed.ts
  • src/index.ts
  • src/mcp/http.ts
  • src/mcp/server.ts
  • src/mcp/standalone.ts
  • src/mcp/tools-registry.ts
  • src/providers/noop.ts
  • src/providers/resilient.ts
  • src/state/kv.ts
  • src/state/schema.ts
  • src/triggers/api.ts
  • src/triggers/events.ts
  • src/types.ts
  • src/utils/trigger-detached.ts
  • src/viewer/index.html
  • src/worker-pidfile.ts
  • test/actions-api-pagination.test.ts
  • test/actions-gc.test.ts
  • test/actions-v2-migration.test.ts
  • test/actions-v2.test.ts
  • test/actions.test.ts
  • test/api-llm-state.test.ts
  • test/api-observe-async.test.ts
  • test/auto-compress.test.ts
  • test/compress-disabled.test.ts
  • test/consistency.test.ts
  • test/copilot-plugin.test.ts
  • test/detached-trigger.test.ts
  • test/env-loader.test.ts
  • test/export-import.test.ts
  • test/frontier.test.ts
  • test/hook-observation-client.test.ts
  • test/hook-project.test.ts
  • test/leases.test.ts
  • test/llm-execution-state.test.ts
  • test/mcp-http.test.ts
  • test/mcp-standalone-proxy.test.ts
  • test/mcp-standalone.test.ts
  • test/mcp-surface-default.test.ts
  • test/metrics-store.test.ts
  • test/observe-implicit-session.test.ts
  • test/project-manifest.test.ts
  • test/queue-config.test.ts
  • test/session-context.test.ts
  • test/session-end-triggers-graph.test.ts
  • test/session-list.test.ts
  • test/state-kv.test.ts
  • test/stop-worker-pidfile.test.ts
  • test/summarize.test.ts
  • test/tool-count-consistency.test.ts
  • test/worker-pidfile.test.ts
  • tsdown.config.ts

📝 Walkthrough

Walkthrough

The PR adds Actions v2 storage and migration, revision-bound pagination, durable asynchronous observation ingestion, richer project/session context, Streamable HTTP MCP support, configurable tool visibility, LLM skip-state metrics, worker PID leases, and related documentation and tests.

Changes

AgentMemory platform

Layer / File(s) Summary
Actions v2 domain and persistence
src/types.ts, src/functions/action-*, src/functions/actions.ts
Adds typed action lifecycle, normalization, readiness classification, append-only events, revision state, locking, migration, pagination, and action garbage collection.
Action integrations
src/functions/{checkpoints,leases,sentinels,frontier,mesh,export-import,routines,sketches,diagnostics}.ts
Routes action mutations through the action store and propagates readiness, revisions, events, and export/import state across existing workflows.
Observation and session APIs
src/functions/observe.ts, src/triggers/api.ts, src/functions/session-*.ts
Adds durable asynchronous observation enqueueing, observation IDs, session context updates, paginated session listing, and session context propagation.
MCP transport and tools
src/mcp/*, src/cli.ts, packages/mcp/*
Adds the Streamable HTTP bridge, expands action/session tool schemas, adds memory_action_list, and supports core, workstation, all, and allowlist tool modes.
Hooks and runtime behavior
src/hooks/*, plugin/scripts/*, src/config.ts, src/eval/metrics-store.ts
Centralizes project context and observation submission, supports configurable prompt/tool capture, skips disabled LLM work with metrics, and replaces void triggers with detached execution.
Operational support
src/worker-pidfile.ts, src/index.ts, iii-config*.yaml, .env.example
Adds worker PID leases, observation queue storage/retry configuration, MCP HTTP settings, and deployment guidance.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

Suggested reviewers: rohitg00

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

@wrightpt
wrightpt deleted the agent/retire-gh-push-triggers branch July 28, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant