Skip to content

feat(connect): Warp adapter — first-class memory citizen - #676

Closed
rohitg00 wants to merge 11 commits into
mainfrom
docs/readme-i18n
Closed

feat(connect): Warp adapter — first-class memory citizen#676
rohitg00 wants to merge 11 commits into
mainfrom
docs/readme-i18n

Conversation

@rohitg00

@rohitg00 rohitg00 commented May 27, 2026

Copy link
Copy Markdown
Owner

Warp Terminal (warp.dev) joins the connect surface.

What ships

  • New `src/cli/connect/warp.ts` (17 LOC via the shared `createJsonMcpAdapter`). Writes the canonical `mcpServers` block to `~/.warp/.mcp.json`.
  • Registered in `ADAPTERS` (12 total, was 11).
  • Test coverage: detect-when-absent, install-writes-config, registered-in-knownAgents. Bumped existing `cli-connect.test.ts` assertion from 11 to 12.
  • README agents grid + "Other agents" config table updated.

Native-citizen win without writing a single hook

Warp's skill discovery already scans `.claude/skills/`, `.codex/skills/`, `.cursor/skills/`, etc. (source). Once a user installs the agentmemory Claude Code plugin, all 8 memory skills (`remember`, `recall`, `recap`, `handoff`, `forget`, `commit-context`, `commit-history`, `session-history`) surface in Warp's slash-command palette with zero extra wiring. Documented in the connect table.

Verification

  • `npm run build` clean
  • `npx vitest run` — 1173 passed, 17 skipped, 1 pre-existing integration test failure (needs running server, unrelated)
  • `agentmemory connect warp --dry-run` flow validated in test fixture

Summary by CodeRabbit

Release Notes

  • New Features

    • Added Warp agent integration via MCP configuration
  • Documentation

    • Introduced language selector and expanded documentation in German, Spanish, French, Hindi, Japanese, Korean, Portuguese (Brazil), Russian, Turkish, Simplified Chinese, and Traditional Chinese
    • Enhanced README with comprehensive setup and configuration guidance

Review Change Stack

rohitg00 added 11 commits May 27, 2026 10:17
Adds top-of-README link row to READMEs/README.{locale}.md files. 11 translations land alongside: zh-CN, zh-TW, ja-JP, ko-KR, es-ES, pt-BR, fr-FR, de-DE, ru-RU, tr-TR, hi-IN.
…r/ru

MD040: add 'text' language tag to the 5 prose-only fenced blocks (lines 431, 482, 507, 705, 738) in source README and propagated to all 11 translations.

Path: de-DE, fr-FR, ru-RU had md links + html href/src to repo-root paths (integrations/, docs/, eval/, benchmark/, src/, deploy/, plugin/, examples/, CHANGELOG, LICENSE, assets/) without ../ prefix — files live in READMEs/, so paths resolved one level too high. Prepended ../ on all matched refs.

Reviewer-flagged ko-KR path issue verified false-positive: that file already had ../ prefix from initial translation.
Warp stores MCP config at ~/.warp/.mcp.json with the same mcpServers schema as Claude Code, so the shared createJsonMcpAdapter wires it in 17 lines. Adds Warp to the connect surface (12 adapters total) and the README agents grid.

Native-citizen second-class win: Warp's skill discovery already scans .claude/skills/ — installing the existing agentmemory Claude Code plugin makes the 8 memory skills (remember, recall, recap, handoff, forget, commit-context, commit-history, session-history) appear in Warp's slash-command palette with zero extra wiring.

Tests bumped: ADAPTERS.length 11 -> 12, knownAgents includes 'warp', new connect-new-agents Warp install case.
@vercel

vercel Bot commented May 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agentmemory Ready Ready Preview, Comment May 27, 2026 11:52am

Request Review

@rohitg00

Copy link
Copy Markdown
Owner Author

Superseded by fresh PR off main — original branch had post-squash drift showing all i18n files as new even though they were identical.

@rohitg00 rohitg00 closed this May 27, 2026
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 26712ece-1f30-41ca-b941-aa1e94dbf0cd

📥 Commits

Reviewing files that changed from the base of the PR and between 26980a8 and e11cc01.

📒 Files selected for processing (16)
  • README.md
  • READMEs/README.de-DE.md
  • READMEs/README.es-ES.md
  • READMEs/README.fr-FR.md
  • READMEs/README.hi-IN.md
  • READMEs/README.ja-JP.md
  • READMEs/README.ko-KR.md
  • READMEs/README.pt-BR.md
  • READMEs/README.ru-RU.md
  • READMEs/README.tr-TR.md
  • READMEs/README.zh-CN.md
  • READMEs/README.zh-TW.md
  • src/cli/connect/index.ts
  • src/cli/connect/warp.ts
  • test/cli-connect.test.ts
  • test/connect-new-agents.test.ts

📝 Walkthrough

Walkthrough

This PR adds support for the Warp agent via a new CLI MCP adapter configuration and introduces comprehensive localized README documentation in 11 languages (German, Spanish, French, Hindi, Japanese, Korean, Portuguese, Russian, Turkish, Simplified Chinese, and Traditional Chinese). The English README is updated with a language selector and Warp integration details.

Changes

Warp CLI Adapter Integration

Layer / File(s) Summary
Warp adapter definition and registration
src/cli/connect/warp.ts, src/cli/connect/index.ts
warp adapter is created via createJsonMcpAdapter with home-directory config at ~/.warp/.mcp.json, and is imported and registered in the ADAPTERS array alongside existing agents.
Warp adapter detection and installation tests
test/connect-new-agents.test.ts, test/cli-connect.test.ts
New Warp test suite verifies detect() and install() behavior, and adapter-count assertions are updated from 11 to 12 agents.

Multilingual Documentation Update

Layer / File(s) Summary
English README with language selector and Warp entry
README.md
Adds multilingual language selector links at the top, includes Warp in "Works with every agent" tables, and standardizes fenced code blocks to use text language tag.
German README
READMEs/README.de-DE.md
Comprehensive German documentation covering installation, agent integration, benchmarks, memory pipeline, MCP server configuration, deployment, and runtime settings.
Spanish README
READMEs/README.es-ES.md
Full Spanish documentation with product overview, agent compatibility, benchmarks, configuration examples, MCP details, and operational guidance.
French README
READMEs/README.fr-FR.md
Extensive French documentation for installation, agent integration, benchmarks, memory architecture, MCP toolkit, viewer/console, and configuration reference.
Hindi README
READMEs/README.hi-IN.md
Complete Hindi documentation including setup, agent integration, benchmarks, memory pipeline, MCP capabilities, and configuration guidance.
Japanese README
READMEs/README.ja-JP.md
Comprehensive Japanese README covering setup, agent integration, benchmarks, memory architecture, MCP configuration, and API reference.
Korean README
READMEs/README.ko-KR.md
Full Korean documentation with installation, agent integration, memory architecture, MCP server details, viewer/console setup, and configuration reference.
Portuguese README
READMEs/README.pt-BR.md
Complete Portuguese documentation with installation, agent integration, benchmarks, memory pipeline, MCP server details, deployment, and configuration reference.
Russian README
READMEs/README.ru-RU.md
Comprehensive Russian documentation covering installation, agent compatibility, benchmarks, memory architecture, MCP capabilities, deployment, and extensive configuration guidance.
Turkish README
READMEs/README.tr-TR.md
Full Turkish documentation with installation, agent integration, configuration guidance, MCP toolkit overview, and operational reference.
Chinese Simplified README
READMEs/README.zh-CN.md
Complete Simplified Chinese documentation covering installation, agent integration, memory architecture, MCP configuration, and API reference.
Chinese Traditional README
READMEs/README.zh-TW.md
Full Traditional Chinese documentation with product overview, installation, agent integration, memory architecture, MCP details, and configuration reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • rohitg00/agentmemory#675: Updates README.md language selector and code fence tags in concert with main PR changes.
  • rohitg00/agentmemory#651: Modifies CLI adapter registry and test expectations, directly related to the Warp adapter registration pattern.

Poem

🐰 A warren of words in a dozen fine tongues,
Warp weaves through the agents where memory clings—
From German to Hindi, from French to Chinese,
The docs bloom like clover, sure pleasing to please. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/readme-i18n

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant