Skip to content

fix: bound sdk.shutdown() so a hung telemetry flush can't block exit #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CryptoQuaternions wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

fix: bound sdk.shutdown() so a hung telemetry flush can't block exit #910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cb7111
fix: bound sdk.shutdown() so a hung telemetry flush can't block exit
CryptoQuaternions Jun 11, 2026
de901b5
refactor: separate timeout and error logging in shutdown handler
CryptoQuaternions Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,18 @@ async function main() {
await indexPersistence.save().catch((err) => {
console.warn(`[agentmemory] Failed to save index on shutdown:`, err);
});
await sdk.shutdown();
// #909 / iii-hq/iii#1835: defensive timeout prevents an indefinite hang when
// the OTel exporter is stuck retrying; un-flushed telemetry is dropped on exit.
const shutdownPromise = sdk.shutdown().catch((err) => {
console.warn(`[agentmemory] sdk.shutdown() errored:`, err);
});
const timeoutPromise = new Promise<void>((resolve) =>
setTimeout(() => {
console.warn(`[agentmemory] sdk.shutdown() exceeded 3s timeout, proceeding to exit`);
resolve();
}, 3000),
);
await Promise.race([shutdownPromise, timeoutPromise]);
clearWorkerPidfile();
process.exit(0);
};
Expand Down