Fix/embedding key resolution

[Noodle05]

Summary by CodeRabbit

Release Notes

• New Features

  • Docker containerization support with Docker Compose for simplified deployment and multi-architecture image builds.
  • MCP Stream HTTP server enabling streamable HTTP client connections with Bearer token authentication.

• Documentation

  • Added Docker Compose setup guide in README with step-by-step instructions.

• Configuration

  • Expanded environment configuration options for REST/MCP networking and viewer host settings.

[vercel]

@Noodle05 is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6cca7cc9-7759-4376-b16c-52205d3d9309

📥 Commits

Reviewing files that changed from the base of the PR and between f6f9e3c and 558b85a.

📒 Files selected for processing (22)

• .dockerignore
• .env.example
• .github/workflows/ci.yml
• .github/workflows/docker-build-publish.yml
• .github/workflows/publish.yml
• Dockerfile
• README.md
• docker-compose.yml
• entrypoint.sh
• src/cli/connect/types.ts
• src/cli/connect/util.ts
• src/config.ts
• src/index.ts
• src/mcp/handler.ts
• src/mcp/standalone.ts
• src/mcp/stream-http.ts
• src/providers/embedding/index.ts
• src/types.ts
• src/viewer/server.ts
• test/mcp-stream-http.test.ts
• test/mcp-transport-coexistence.test.ts
• test/multi-instance-port.test.ts

---

📝 Walkthrough

Walkthrough

Adds a hand-rolled MCP Streamable HTTP server (stream-http.ts) on a configurable mcpPort, extracts shared MCP tool-handling logic from standalone.ts into handler.ts, wires the new server into startup/shutdown in index.ts, and extends AgentMemoryConfig with mcpPort. Also introduces complete Docker deployment infrastructure: multi-stage Dockerfile, entrypoint.sh with HMAC-secret bootstrapping, updated docker-compose.yml, a new GHCR publish workflow, and a README Docker section.

Changes

MCP Streamable HTTP Transport and Docker Deployment

Layer / File(s)	Summary
mcpPort config contract and derivation src/types.ts, src/config.ts	AgentMemoryConfig gains mcpPort: number; loadConfig() derives it from AGENTMEMORY_MCP_PORT or restPort + 3.
Shared MCP tool handler extraction src/mcp/handler.ts, src/mcp/standalone.ts	handler.ts (442 lines) defines IMPLEMENTED_TOOLS, per-tool argument validation, handleProxy REST dispatch, handleLocal InMemoryKV fallback, handleProxyGeneric, and exported handleToolCall/handleToolsList. standalone.ts is gutted (−422 lines) and now delegates to handler.ts.
MCP Streamable HTTP server src/mcp/stream-http.ts	New 331-line hand-rolled JSON-RPC-over-HTTP server with bounded body reading (5 MB), BodyTooLargeError, session map with periodic idle eviction, timing-safe Bearer auth, DELETE session support, and routing for initialize/tools/list/tools/call.
Server startup, shutdown, and CLI wiring src/index.ts, src/cli/connect/types.ts, src/cli/connect/util.ts, src/viewer/server.ts, src/providers/embedding/index.ts	index.ts starts mcpServer on config.mcpPort and awaits mcpServer.shutdown() in teardown. ConnectAdapter.category gains "stream-http". AGENTMEMORY_MCP_HTTP_BLOCK exports the Streamable HTTP client config. Viewer REST upstream host becomes env-configurable; embedding provider drops explicit API key arg.
Docker build, entrypoint, and Compose Dockerfile, entrypoint.sh, docker-compose.yml, .dockerignore, .env.example	Multi-stage Dockerfile copies iii binary and builds via node:22-slim. entrypoint.sh prepares /data, rewrites iii-config.yaml, generates/persists HMAC secret on first boot, starts iii in background, and runs agentmemory in foreground under tini. docker-compose.yml replaces iii-init/iii-engine with a single agentmemory service with healthcheck. .env.example documents new env vars.
CI/CD workflow changes .github/workflows/docker-build-publish.yml, .github/workflows/ci.yml, .github/workflows/publish.yml	Adds docker-build-publish.yml for multi-arch GHCR image on release/dispatch. Removes auto-triggers from ci.yml (push/PR) and publish.yml (release); both now require manual dispatch.
MCP stream HTTP and transport coexistence tests test/mcp-stream-http.test.ts, test/mcp-transport-coexistence.test.ts, test/multi-instance-port.test.ts	937-line test suite covers initialize, tools/list, tools/call, Bearer auth, JSON-RPC errors, session management, notifications, HTTP method/content-type validation, payload size limits, DELETE, and session eviction. Coexistence tests validate identical tool sets between HTTP and direct handler (T016) and notification handling (T017). Port tests extend to assert mcpPort derivation and pinning.
README Docker section README.md	Adds Docker subsection with Compose commands, HMAC secret extraction, Streamable HTTP MCP client config snippet, stdio shim guidance, and quickstart link.

Sequence Diagram(s)

sequenceDiagram
  participant Client as MCP Client
  participant StreamHTTP as stream-http.ts server
  participant Handler as handler.ts
  participant KV as InMemoryKV / REST proxy

  rect rgba(70, 130, 180, 0.5)
    note over Client, StreamHTTP: initialize
    Client->>StreamHTTP: POST /mcp {method: "initialize"}
    StreamHTTP->>StreamHTTP: create session, set lastUsedAt
    StreamHTTP-->>Client: JSON-RPC result + Mcp-Session-Id
  end

  rect rgba(34, 139, 34, 0.5)
    note over Client, KV: tools/call
    Client->>StreamHTTP: POST /mcp {method: "tools/call", Mcp-Session-Id}
    StreamHTTP->>StreamHTTP: validate session + update lastUsedAt
    StreamHTTP->>Handler: handleToolCall(toolName, args, sdk, kv)
    Handler->>KV: proxy REST or local InMemoryKV
    KV-->>Handler: result
    Handler-->>StreamHTTP: content array
    StreamHTTP-->>Client: JSON-RPC result
  end

  rect rgba(178, 34, 34, 0.5)
    note over Client, StreamHTTP: session deletion
    Client->>StreamHTTP: DELETE /mcp (Mcp-Session-Id)
    StreamHTTP->>StreamHTTP: delete session from map
    StreamHTTP-->>Client: 200
  end

Loading

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

• rohitg00/agentmemory#503: Changes OpenAIEmbeddingProvider constructor to resolve the API key internally, directly related to this PR's removal of the explicit getEnvVar("OPENAI_API_KEY") argument in createEmbeddingProvider().
• rohitg00/agentmemory#815: Modifies loadConfig() port-derivation logic and test/multi-instance-port.test.ts, the same files this PR extends to add mcpPort derivation.
• rohitg00/agentmemory#887: Modifies ConnectAdapter.category in src/cli/connect/types.ts, the same field this PR extends with the "stream-http" value.

Suggested reviewers

• rohitg00

Poem

🐇 Hop, hop — the stream runs free,
JSON-RPC dancing over HTTP!
Sessions born and secrets grown,
A Docker nest I call my home.
tini guards with gentle care,
While MCP tools float through the air. ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}