Skip to content

Fix missing empty base optimization on MSVC - #61

Merged
rollbear merged 1 commit into
rollbear:mainfrom
marzer:fix-msvc-ebco
Jul 15, 2026
Merged

Fix missing empty base optimization on MSVC#61
rollbear merged 1 commit into
rollbear:mainfrom
marzer:fix-msvc-ebco

Conversation

@marzer

@marzer marzer commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Fixes #60.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ed2d547) to head (2eb9a8b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          403       403           
=========================================
  Hits           403       403           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rollbear

Copy link
Copy Markdown
Owner

This looks good, but I don't understand what goes wrong with is_regular and diff.

@marzer

marzer commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Huh, me neither, this wasn't happening for me locally on my version of MSVC. I'll test it against a few additional versions of the toolchain and try to figure something out.

@marzer

marzer commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Alrighty @rollbear I've addressed this such that it passes locally on a couple of different MSVC toolchains, so should be ready to try again in your CI.

@rollbear
rollbear merged commit c657d5f into rollbear:main Jul 15, 2026
93 checks passed
@rollbear

Copy link
Copy Markdown
Owner

Awesome! Thank you!

@marzer
marzer deleted the fix-msvc-ebco branch July 16, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use __declspec(empty_bases) on MSVC

2 participants