Repository navigation
fix: add gap between footer contact links - #120
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
romahawk
force-pushed
the
fix/footer-contact-gap
branch
from
October 14, 2026 16:28
f03479e to
b0ca345
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
In the footer's Contact column, the "Download CV" button and the email link touched each other with no space between them, on every page and at every width. This adds a gap.
No linked issue.
Changes
CSS (
src/assets/css/footer.css).footer__cta-colbecomes a wrapping flex row withgap: 12px 20px: 20px between the button and the email link, 12px between rows when they wrap. The "Contact" heading takes its own rowmargin-top: 12pxis removed (the gap replaces it). The heading's bottom margin in this column is 2px, so heading to button stays 14px, as in the other footer columnsVerification
npm run lintexits 0npm run buildexits 0 (this runsscripts/check-consistency.mjsfirst)Local check on
vite previewwith headless Edge, light theme, at 1366px and 390px: the button and email link sit side by side with a clear gap.How to test
/,/servicesand/aiCore loop: home → Work → a proof link → Contact (email copy, CV download) still works.
Not tested: real iOS Safari / Android Chrome, dark mode.
Quality gates
aria-labelon icon-only controls, focus rings,prefers-reduced-motionLucide icons use named imports and are registered in the component's(no icon changes)ICONSmapRedirects in(no route changes)vercel.jsonchecked if a route was added, moved or removedDocs
CHANGELOG.mdupdated under[Unreleased](CSS only)docs//CLAUDE.mdupdated if architecture, routing or scope changedScreenshots
Taken locally, not attached.
Notes for review
Rebased onto
mainafter #119 merged, so the Vercel preview also shows the new/ai. The CHANGELOG conflict is resolved: both entries are kept, with this one on top.🤖 Generated with Claude Code