Fix a number of clang-tidy detected defects

[jblomer]

A test run of clang-tidy on the RNTuple code with the following checks

Checks: 'bugprone-*,
   -bugprone-assignment-in-if-condition,
   -bugprone-branch-clone,
   -bugprone-derived-method-shadowing-base-method,
   -bugprone-easily-swappable-parameters,
   -bugprone-implicit-widening-of-multiplication-result,
   -bugprone-incorrect-enable-if,
   -bugprone-macro-parentheses,
   -bugprone-multi-level-implicit-pointer-conversion,
   -bugprone-narrowing-conversions,
   -bugprone-not-null-terminated-result,
   -bugprone-random-generator-seed,
   -bugprone-reserved-identifier,
   -bugprone-signed-char-misuse,
   -bugprone-std-namespace-modification,
   -bugprone-switch-missing-default-case,
   -bugprone-throwing-static-initialization,
   -bugprone-too-small-loop-variable,
   -bugprone-unchecked-optional-access,
   -bugprone-unhandled-self-assignment,
   -bugprone-unused-return-value,
   -bugprone-virtual-near-miss,
   cppcoreguidelines-virtual-class-destructor,
   misc-*,
   -misc-non-private-member-variables-in-classes,
   -misc-include-cleaner,
   -misc-misplaced-const,
   -misc-multiple-inheritance,
   -misc-no-recursion,
   -misc-non-private-member-variables-in-classes,
   -misc-predictable-rand,
   -misc-unconventional-assign-operator,
   -misc-use-anonymous-namespace,
   performance-*,
   -performance-enum-size,
   -performance-inefficient-string-concatenation,
   -performance-no-int-to-ptr,
   -performance-noexcept-swap,
   -performance-noexcept-move-constructor,
   readability-duplicate-include,
   readability-delete-null-pointer,
   readability-misleading-indentation,
   readability-redundant-control-flow,
   readability-redundant-declaration,
   readability-redundant-function-ptr-dereference,
   readability-reference-to-constructed-temporary'

[github-actions]

Test Results

    22 files      22 suites   3d 8h 29m 21s ⏱️
 3 871 tests  3 871 ✅ 0 💤 0 ❌
75 247 runs  75 247 ✅ 0 💤 0 ❌

Results for commit afe3c4e.

♻️ This comment has been updated with latest results.

[dpiparo]

Thanks for these changes! Would it be useful to expand this kind of campaigns to other portions of the codebase, e.g. roofit or RDF, or explore other checks?

[pcanal]

LGTM.

[ferdymercury]

Thanks for this, it's great!

Thanks for these changes! Would it be useful to expand this kind of campaigns to other portions of the codebase, e.g. roofit or RDF, or explore other checks?

Yes. Maybe even sth like:
https://github.com/HorstBaerbel/action-clang-tidy
or
https://github.com/marketplace/actions/clang-tidy-review
https://github.com/marketplace/actions/c-c-linter

[jblomer]

Thanks for this, it's great!

Thanks for these changes! Would it be useful to expand this kind of campaigns to other portions of the codebase, e.g. roofit or RDF, or explore other checks?

Yes. Maybe even sth like: https://github.com/HorstBaerbel/action-clang-tidy or https://github.com/marketplace/actions/clang-tidy-review https://github.com/marketplace/actions/c-c-linter

Maybe. I think the next step would be a regular clang-tidy check for RNTuple as part of the CI. Looking into it.

[hahnjo]

LGTM

[silverweed]

Thanks! I have just a few comments