Add GH20033 regression test for joined processors#22702
Add GH20033 regression test for joined processors#22702matildamarjamaki wants to merge 3 commits into
Conversation
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thank you! I have left some minor comments to improve the layout of the test, the changes already look quite good.
|
|
||
| using GH20033ProcessorConfig = std::tuple<bool, bool, bool, bool>; | ||
|
|
||
| class GH20033ProcessorTest : public testing::TestWithParam<GH20033ProcessorConfig> { |
There was a problem hiding this comment.
As we did in the other PR, I think it would be good here to include a comment linking this test to the equivalent TTree test introduced by #20222
| "gh20033_rntuple_stepzero_1.root" | ||
| }; | ||
|
|
||
| // Muut analyysivaiheet omissa tiedostoissaan |
There was a problem hiding this comment.
Before merging it would be good to translate comments to English
| std::unique_ptr<RNTupleProcessor> CreateStepProcessor(std::string_view ntupleName, | ||
| const std::string &fileName, | ||
| bool useChain) |
There was a problem hiding this comment.
| std::unique_ptr<RNTupleProcessor> CreateStepProcessor(std::string_view ntupleName, | |
| const std::string &fileName, | |
| bool useChain) | |
| std::unique_ptr<RNTupleProcessor> CreateStepProcessor(std::string_view ntupleName, | |
| std::string_view fileName, | |
| bool useChain) |
Just for consistency, let's use std::string_view for both arguments. Or equivalently you can use const std::string & for both
| { | ||
| if (useChain) { | ||
| std::vector<RNTupleOpenSpec> specs{{std::string(ntupleName), fileName}}; | ||
| return RNTupleProcessor::CreateChain(specs, std::string(ntupleName)); |
There was a problem hiding this comment.
| return RNTupleProcessor::CreateChain(specs, std::string(ntupleName)); | |
| return RNTupleProcessor::CreateChain(specs); |
as per the documentation
processorName The name to give to the processor. If empty, the name of the input RNTuple is used.
| return RNTupleProcessor::CreateChain(specs, std::string(ntupleName)); | ||
| } | ||
|
|
||
| return RNTupleProcessor::Create({std::string(ntupleName), fileName}, std::string(ntupleName)); |
There was a problem hiding this comment.
| return RNTupleProcessor::Create({std::string(ntupleName), fileName}, std::string(ntupleName)); | |
| return RNTupleProcessor::Create({std::string(ntupleName), fileName}); |
as per the documentation
processorName The name to give to the processor. If empty, the name of the input RNTuple is used.
Test Results 23 files 23 suites 3d 16h 35m 36s ⏱️ For more details on these failures, see this check. Results for commit 77a2d61. ♻️ This comment has been updated with latest results. |
2 participants
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #