[Python][CodeQL] Add explicit ownership check#22715
Open
siliataider wants to merge 3 commits into
Open
Conversation
Test Results 22 files 22 suites 3d 11h 10m 7s ⏱️ For more details on these failures, see this check. Results for commit 1db090f. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Small cleanup:
CodeQL flags
if True:as a constant conditional.Replaced it with explicit
__python_owns__checks before/afteraddOwnedwhich is what we really want to verify.Also fixed the duplicate
TestRooArgListtest class: two classes in this file were both namedTestRooArgList, so the second silently overwrote the first and its test never ran. Renamed it toTestRooCmdArg