[CMake] Fix build failure when root is configured with -Dtesting=Off.#22716
Merged
Conversation
The addition of "test_roofit_hs3testsuite" broke all CI builds with -Dtesting=Off (e.g. the doxygen builds), because test_roofit_hs3testsuite=On and testing=Off triggers a FATAL_ERROR. Here, we make testing=Off into a global switch that has precedence over test_roofit_hs3testsuite=On.
2 tasks
jblomer
approved these changes
Jun 26, 2026
guitargeek
approved these changes
Jun 26, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I originally wanted to go for the error here to prevent disappointment that your test_roofit_hs3testsuite=ON would be silently ignored, but now I see that this is impractical.
Test Results 22 files 22 suites 3d 10h 54m 7s ⏱️ Results for commit 4230978. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of "test_roofit_hs3testsuite" broke all CI builds with -Dtesting=Off (e.g. the doxygen builds), because
test_roofit_hs3testsuite=On and testing=Off
triggers a FATAL_ERROR.
Here, we convert testing=Off into a global switch that has precedence over test_roofit_hs3testsuite=On.