Skip to content

[math] Fix a debian build failure with -Werror#22717

Merged
hageboeck merged 1 commit into
root-project:masterfrom
hageboeck:debian_build_failure
Jun 26, 2026
Merged

[math] Fix a debian build failure with -Werror#22717
hageboeck merged 1 commit into
root-project:masterfrom
hageboeck:debian_build_failure

Conversation

@hageboeck

Copy link
Copy Markdown
Member

On debian, gcc warns about a dangling else, which triggers a build error.

@hageboeck hageboeck self-assigned this Jun 26, 2026
@hageboeck hageboeck requested a review from guitargeek as a code owner June 26, 2026 14:06
@hageboeck

hageboeck commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

Followup of #22700, which didn't catch the same warning in the CI run. It caught the warning, but it didn't provoke the error.

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I also don't understand why the original PR didn't give an error.

@github-actions

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 15h 38m 10s ⏱️
 3 876 tests  3 859 ✅   0 💤 17 ❌
79 726 runs  79 567 ✅ 142 💤 17 ❌

For more details on these failures, see this check.

Results for commit 7e6868f.

@hageboeck hageboeck merged commit 8bee4d5 into root-project:master Jun 26, 2026
32 of 34 checks passed
@hageboeck hageboeck deleted the debian_build_failure branch June 26, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants