[webgui] adjust chrome headless flags - #23084
Open
linev wants to merge 1 commit into
Open
Conversation
Starting from version 151 one have to allow use of unsafe swiftshader using flag "--enable-unsafe-swiftshader"; And in docker disable shared memory usage because of limited resources using flag "--disable-dev-shm-usage";
Test Results 23 files 23 suites 3d 21h 40m 23s ⏱️ For more details on these failures, see this check. Results for commit 814a027. ♻️ This comment has been updated with latest results. |
dpiparo
reviewed
Aug 20, 2026
| if (fChromeVersion > 150) | ||
| extra_arg = "--enable-unsafe-swiftshader"; | ||
| // in docker disable shared memory usage because of limited resources | ||
| if (!gSystem->AccessPathName("/.dockerenv", kFileExists)) |
Member
There was a problem hiding this comment.
I am a bit scared of changing the behaviour of ROOT at runtime based on the fact that a container is running. Are there any alternatives we can explore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from version 151 one have to allow use of unsafe swiftshader using flag "--enable-unsafe-swiftshader";
And in docker disable shared memory usage because of limited resources using flag "--disable-dev-shm-usage";