[cmake] Do not auto force-enable or force-disable user CMake build options - #23092
Open
ferdymercury wants to merge 10 commits into
Open
[cmake] Do not auto force-enable or force-disable user CMake build options#23092ferdymercury wants to merge 10 commits into
ferdymercury wants to merge 10 commits into
Conversation
Test Results 23 files 23 suites 3d 19h 3m 27s ⏱️ For more details on these failures, see this check. Results for commit dbb1487. ♻️ This comment has been updated with latest results. |
ferdymercury
marked this pull request as ready for review
August 18, 2026 10:55
…tions Messing up with the cache is dangerous, and users often complain about not having the control since the build system changes what they just passed as flag to the command line. Instead, convert these automatism into a helpful error message that the user can use as a hotfix to modify their build flags. This prevents surprises, annoying behind-the-scene changes, as well as bugs. Follows up on the phillosophy of root-project#23020 Fixes https://its.cern.ch/jira/browse/ROOT-10743
When cuda=On, but no viable compiler can be found, CMake produces the hard-to-understand error: Cannot determine link language of RooBatchCompute_CUDA. by hageboeck, cherrypicked from https://github.com/root-project/root/pull/23091/commits
ferdymercury
force-pushed
the
unforcecache
branch
from
August 18, 2026 14:40
e96b03f to
195baf7
Compare
Member
|
@ferdymercury Can you add a comment to close the now seemingly superseded #18413 explaining where we actually ended up? |
pcanal
marked this pull request as draft
August 18, 2026 15:33
ferdymercury
force-pushed
the
unforcecache
branch
from
August 18, 2026 15:47
fc53441 to
59dfd0d
Compare
ferdymercury
added
the
skip code analysis
Collaborator
Author
|
Sure, comment added: #18413 (comment) |
ferdymercury
marked this pull request as ready for review
August 18, 2026 15:56
pcanal
reviewed
Aug 18, 2026
2 tasks
…nd split multioptions and fix conflicting ssl=OFF vs builtin_openssl=ON on macos hotfix help message
Before, there was a subordinate hierarchical dependency, testing required testsupport. Now they have a logical OR relationship, GTest will be a dependency if one or the other is enabled.
pcanal
reviewed
Aug 19, 2026
pcanal
reviewed
Aug 19, 2026
as suggested by pcanal
ferdymercury
force-pushed
the
unforcecache
branch
from
August 19, 2026 15:10
23cb983 to
dbb1487
Compare
Collaborator
Author
|
(asan failure seems unrelated) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messing up with the cache is dangerous (calling to problems), and users often complain about not having the control since the build system changes what they just passed as flag to the command line. Instead, convert these automatism into a helpful error message that the user can use as a hotfix to modify their build flags. This prevents surprises, annoying behind-the-scene changes, as well as bugs. Follows up on the philosophy of #23020
Fixes https://its.cern.ch/jira/browse/ROOT-10743