[builtins] mv mathjax to LCG - #23099
Conversation
Test Results 22 files 22 suites 3d 12h 47m 1s ⏱️ For more details on these failures, see this check. Results for commit 570d0b0. ♻️ This comment has been updated with latest results. |
|
Optional improvement: LCG contains a mathjax package, so the link could be moved to LCG https://lcgpackages.web.cern.ch/tarFiles/sources/mathjax.tar.gz |
|
If we do not remove And one need to understand reason why CI fails. |
|
That was fast. Thanks. I think the technical implementation of this is perfect, however by policy perhaps we are not yet ready for this change, see #23100 |
Right. (Although mathjax is maybe an optional dependency of webgui meaning it can still build and show several stuff without it?) Could an alternative be to have Mathjax as a normal builtin_mathjax option? Installed by the user from system packages and backed-up by LCG link? I think it would be for the different platforms whereas Windows would need builtin_mathjax=ON (internet connection) |
I checked that it install. Anyway we download lot of packages from LCG, |
I guess via:
or wherever the system installs it |
fixes build errors seen in clean-build CI
|
Thanks for these exchanges. Very useful. Now we can discuss with a bit of calm with the builds un-broken...
That is the very least of the problems. Doxygen doc generation is special and we can afford to fetch mathjax from LCG w/o problems if needed I think.
Definitively yes, I think: that would be a good way to treat MathJax as any other 3rd party dependency, coherently. Two questions are perhaps important:
|
This need to be investigated. Main complication I see - correctly recognize installed Down line for this - it is not trivial task. |
Yes. However that would be a change with respect to the current policy: we would impose internet connection and download of a builtin for the standard ROOT build, unless we decide that the standard rendering is what jsroot provides, and, as a plus, one can decide to go for mathjax, which will be fetch from the LCG src tarballs. |
Brew was missing, I proposed it now: Homebrew/homebrew-core#299582
Probably not yet, I think it should handle at least v2, v3 and v4 of MathJax since those are common in today's distributions. Right now it would only handle v3 I guess.
I proposed a draft here: #23101
I implemented this idea in this PR by using a warning if no-connection is detected rathar than a failure. |
|
jsroot not yet work with matjax 4. There are some initialization problems. |
fixes recent build errors seen in CI such as https://github.com/root-project/root/actions/runs/32186953507/job/95872677396?pr=23089
follow-up of #23095