Add explicit review target selection - #78
Open
dbrosio3 wants to merge 4 commits into
Open
Conversation
dbrosio3
marked this pull request as ready for review
August 13, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review.target_branchas the configured default while detecting ambiguous review basespushgate.review-target=<ref>overrideWhy
Choosing the wrong comparison base can produce an inflated changed-line count and incorrectly block a push through
ai.max_changed_lines. This PR makes the comparison target explicit when local Git state offers multiple plausible bases.Related investigation: https://app.notion.com/p/39f59347eba68032bb83e9fdafe8cad5
Developer impact
Unambiguous pushes continue using the configured target without prompting. Ambiguous interactive pushes ask the developer to choose a target; ambiguous non-interactive pushes fail closed with override guidance. Pushgate does not fetch or mutate refs during selection.
Validation
pnpm run typecheckworkflow-run-plan,terminal,pre-push-stdin, andwarning-confirmationpnpm run bundlegit diff --check