Skip to content

Run browser tests on the GPU on Linux - #95

Merged
roprgm merged 1 commit into
mainfrom
linux-gpu-browser-tests
Oct 14, 2026
Merged

roprgm merged 1 commit into
mainfrom
linux-gpu-browser-tests

Conversation

@roprgm

@roprgm roprgm commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Change

On Linux, Playwright's Chromium now uses the machine's GPU through ANGLE on Vulkan instead of SwiftShader, so the browser suite runs in about a minute instead of 5+ and no longer times out under parallel workers. macOS is unchanged; Windows keeps SwiftShader. The editing test had a race: it read the mask's curve histogram before the exposure change reached it. It now waits for the histogram to change, and it gets the 90 s timeout the other long workflows already use.

Verification

  • Linux (Intel Arc, Mesa Vulkan): bun run test:browser three times in a row: 81 passed, 1 skipped (HEIC: Playwright's Chromium has no HEVC decoder on Linux), ~1 min each. Before: 5.3 min with 2 workers on SwiftShader; with default workers, many timeouts.
  • bun run test (68 pass), bun run check, bun run build.
  • macOS flags are unchanged; not re-run on a Mac.
  • Linux now needs a GPU with a Vulkan driver for browser tests; CI does not run them.

🤖 Generated with Claude Code


Devin Review

Summary by CodeRabbit

  • Tests
    • Expanded coverage of mask exposure adjustments to verify that histogram values respond to changes.
    • Increased the time allowed for editing workflow checks to complete.
    • Updated browser test settings for platform-specific graphics rendering.

ANGLE on Vulkan gives headless Chromium the machine's GPU in place of
SwiftShader. The editing test waits for the mask's histogram to change
after exposure instead of reading a stale one, and gets the 90 s timeout
the other long workflows have.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
openlight Ready Ready Preview Oct 14, 2026 7:20pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: ef404359-9dbf-435d-877c-a7e4dcd2b115
📥 Commits

Reviewing files that changed from the base of the PR and between e317d3b and 40facf6.

📒 Files selected for processing: 2
  • playwright.config.ts
  • tests/editing.e2e.ts
 ________________________________________
< CI is red. I'm also red. We match now. >
 ----------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@roprgm
roprgm merged commit 8627080 into main Oct 14, 2026
4 of 5 checks passed

This branch was successfully deployed

1 active deployment
Preview — 40facf62 Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant