Allow unnamed composable nodes in XML and YAML frontends - #554
Open
Old-Ding wants to merge 2 commits into
Open
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Allow regular composable nodes to omit the frontend name attribute so the plugin can use its default name. Keep names required for composable lifecycle nodes because autostart initializes lifecycle event handling before the container can return a default name. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Old-Ding
force-pushed
the
codex/optional-composable-node-name
branch
from
July 12, 2026 17:59
f617e24 to
9ee24b4
Compare
Only lifecycle autostart needs a name before the component container returns its default name. Let XML and YAML frontends omit the name when autostart is disabled, while retaining the existing guard for enabled or substituted autostart values. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameattribute optional in the shared XML/YAML parser, matching the PythonComposableNodeAPITesting
nameAttributeErrorwith both real launch frontendsament_flake8on both follow-up filesament_pep257on both follow-up filesament_copyrighton both follow-up filespython -m py_compileon both follow-up filesgit diff --checkThe repository-native frontend test was not run locally because this Windows environment does not have the compiled ROS message packages or
rclpy. The focused probes used the reallaunch_xmlandlaunch_yamlfrontends and replaced only the unavailable ROS import boundary.