Move test_cli_remapping into test_cli - #599
Open
Aaravanand00 wants to merge 1 commit into
Open
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Aaravanand00
force-pushed
the
fix-issue-279
branch
from
July 29, 2026 08:35
5a16452 to
7879b05
Compare
Contributor
Author
|
In this PR, I have resolved issue #279 by moving the test_cli_remapping package into the test_cli package.
I have tested the build locally and it compiles successfully. The tests are ready let me know if any changes are needed... |
fujitatomoya
approved these changes
Jul 31, 2026
fujitatomoya
left a comment
fujitatomoya
left a comment
Contributor
There was a problem hiding this comment.
lgtm with green CI.
Contributor
|
Pulls: #599
|
Signed-off-by: Aaravanand <aaravanand@gmail.com>
Aaravanand00
force-pushed
the
fix-issue-279
branch
from
August 1, 2026 05:53
7879b05 to
ca3b1fb
Compare
Contributor
Author
|
@fujitatomoya ptal |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates the
test_cli_remappingpackage into thetest_clipackage to reduce the overhead of having too many granular test packages, keeping related CLI tests together.All source files for the remapping tests have been moved into
test_cli/test/and the build configurations (CMakeLists.txtandpackage.xml) have been merged accordingly. The oldtest_cli_remappingpackage has been entirely removed.Fixes #279
Is this user-facing behavior change?
No, this is purely an internal structural change to consolidate testing packages.
Did you use Generative AI?
I did use generative AI in some form in making the content of this
pull request.
Additional Information
test_clisuccessfully builds with the newly migrated remapping test (name_maker_rclcppexecutable andtest_cli_remapping.pylaunch test).launch_testing_ros,launch_testing_ament_cmake,test_msgs, etc.) have been moved over totest_cli.