fix: remove hardcoded personal paths from README and build script (#8) - #6
Open
rsmxingu wants to merge 1 commit into
Open
fix: remove hardcoded personal paths from README and build script (#8)#6rsmxingu wants to merge 1 commit into
rsmxingu wants to merge 1 commit into
Conversation
Machine-specific references to the original author's home directory ("raul")
leaked into the repo and break for anyone else:
- README.md: the three "Code Architecture" links pointed at
file:///home/raul/Devel/Utilities/YAFW/*.py absolute local paths. Replaced
with repo-relative links (main.py, ui.py, processor.py) that work on GitHub
and in clones.
- README.md: the concept-mockup image referenced the raul/YAFW GitHub repo;
updated the owner/branch to rsd/YAFW@master to match the actual repository.
- build_windows.py: the native ISCC (Inno Setup) lookup list hardcoded
C:\Users\raul\...\Antigravity IDE\...\ISCC.exe as the first candidate.
Replaced with portable lookups: PATH (shutil.which) first, then the standard
32-bit and 64-bit "Program Files\Inno Setup 6" locations.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Machine-specific references to the original author's home directory (
raul) leaked into the repo and break for everyone else.Changes
file:///home/raul/Devel/Utilities/YAFW/*.pyabsolute local paths. Replaced with repo-relative links (main.py,ui.py,processor.py) that work on GitHub and in any clone.raul/YAFW; updated the owner/branch torsd/YAFW@masterto match the actual repository.C:\Users\raul\...\Antigravity IDE\...\ISCC.exeas the first candidate. Replaced with portable lookups:PATH(shutil.which) first, then the standard 32-bit and 64-bitProgram Files\Inno Setup 6locations.grep -rn "raul"over the repo now returns nothing.Testing
python3 -m py_compile build_windows.pypasses.🤖 Generated with Claude Code