-
Notifications
You must be signed in to change notification settings - Fork 9
chore(rstack): add SVG logo variants #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SoonIter
wants to merge
5
commits into
rstackjs:main
Choose a base branch
from
SoonIter:codex/add-rstack-logo-variants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0953441
chore(rstack): add SVG logo variants
SoonIter ae3de02
chore(rstack): optimize simplified SVGs for Material Icon Theme
SoonIter d0922e7
chore(rstack): remove Rslim logo variants
SoonIter fc134b4
chore(rstack): optimize website SVG logos
SoonIter 0d24639
chore(rstack): optimize avatar SVG logos
SoonIter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Rstack logo variants | ||
|
|
||
| SVG logo variants for the Rstack family: | ||
|
|
||
| - [`avatar`](./avatar): full-size circular avatar icons | ||
| - [`website`](./website): compact icons for websites and product surfaces | ||
| - [`simplified`](./simplified): simplified product marks | ||
|
|
||
| Each directory contains icons for Rspack, Rsbuild, Rslib, Rspress, Rsdoctor, | ||
| Rstest, Rslint, and Rslim. | ||
|
|
||
| After deployment, each file is available from `https://assets.rspack.rs/` using | ||
| its repository path. For example: | ||
|
|
||
| ```text | ||
| https://assets.rspack.rs/rstack/logos/avatar/rspack.svg | ||
| ``` | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reviewed commit contains no
rslim.svgin any of the three directories—or anywhere else in its tree—despite this sentence promising an Rslim icon in each directory. Because repository paths are deployed verbatim, readers following this inventory will construct asset URLs that return no file; either add the three advertised assets or remove Rslim from the list.AGENTS.md reference: AGENTS.md:L11-L13
Useful? React with 👍 / 👎.