fix: build Rspack CI binding for unit tests - #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Rslib ecosystem CI job started failing after Rspack #15209 made
rspack_loader_testingoptional behind thetest-loaderCargo feature. The suite built Rspack with the release profile, which intentionally excludes internal test loaders, and then ran unit tests that resolvebuiltin:test-*; this caused 14 failures withUnable to resolve loader builtin:test-*in the failed job.This change builds the Rspack workspace with the
cibinding profile and then builds its JavaScript packages. Theciprofile inherits from release while retaining the internal test loaders required bytest:unit.Validation
pnpm lint pnpm test --stack rslib --suite-commit a74d7f6316ceef4978e5531119810c7d5b097270 rspackThe regression run completed with 47 test suites passed and 9,206 tests passed (4 skipped).
Related Links