Skip to content

feat: support skipping package overrides #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Aug 19, 2026
Merged

feat: support skipping package overrides #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/rsbuild/examples.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ export async function test(options: RunOptions) {
...options,
repo: 'rstackjs/rstack-examples',
branch: 'main',
skipPackageOverrides: [
// TODO: Remove after @rsbuild/plugin-solid v2 has a stable release.
'@rsbuild/plugin-solid',
],
test: ['build:rsbuild'],
});
}
3 changes: 3 additions & 0 deletions tests/shared/rslib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ export async function test(options: RunOptions) {
...options,
repo: 'web-infra-dev/rslib',
branch: process.env.RSLIB ?? 'main',
// TODO: Remove after @rsbuild/plugin-solid v2 has a stable release.
skipPackageOverrides:
options.stack === 'rsbuild' ? ['@rsbuild/plugin-solid'] : undefined,
build: 'node --run build',
// ignore snapshot changes
test: ['testu', 'test:e2e'],
Expand Down
2 changes: 2 additions & 0 deletions types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ export interface RepoOptions {
commit?: string;
shallow?: boolean;
overrides?: Overrides;
/** Package names excluded from automatically generated stack overrides. */
skipPackageOverrides?: string[];
}

export interface Overrides {
Expand Down
13 changes: 13 additions & 0 deletions utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ export async function runInRepo(options: RunOptions & RepoOptions) {
await testCommand?.(pkg.scripts);
}
const overrides: Overrides = { ...(options.overrides || {}) };
const skippedPackageOverrides = new Set(options.skipPackageOverrides);

if (
activeStack === 'rsbuild' ||
Expand All @@ -463,6 +464,9 @@ export async function runInRepo(options: RunOptions & RepoOptions) {
const packages = await getMonorepoPackages(activeStack);
if (options.release) {
for (const pkgInfo of packages) {
if (skippedPackageOverrides.has(pkgInfo.name)) {
continue;
}
if (
overrides[pkgInfo.name] &&
overrides[pkgInfo.name] !== options.release
Expand All @@ -475,6 +479,9 @@ export async function runInRepo(options: RunOptions & RepoOptions) {
}
} else {
for (const pkgInfo of packages) {
if (skippedPackageOverrides.has(pkgInfo.name)) {
continue;
}
overrides[pkgInfo.name] ||= pkgInfo.directory;
}
}
Expand Down Expand Up @@ -503,6 +510,9 @@ export async function runInRepo(options: RunOptions & RepoOptions) {
];
if (options.release) {
for (const pkgInfo of packageList) {
if (skippedPackageOverrides.has(pkgInfo.name)) {
continue;
}
if (
overrides[pkgInfo.name] &&
overrides[pkgInfo.name] !== options.release
Expand All @@ -516,6 +526,9 @@ export async function runInRepo(options: RunOptions & RepoOptions) {
} else {
await patchBindingPackageJson(binding);
for (const pkgInfo of packageList) {
if (skippedPackageOverrides.has(pkgInfo.name)) {
continue;
}
overrides[pkgInfo.name] ||= pkgInfo.directory;
}
}
Expand Down
Loading