chore(lint): forbid value imports of tool packages in extension source - #16
Merged
Conversation
Resolve-from-project (adaptation #3) means the extension may only take types from @rslint/core, @rstest/core, rstack and jiti at compile time; runtime modules are loaded from the user's project through explicit paths. Enforce it with @typescript-eslint/no-restricted-imports (allowTypeImports) over packages/vscode/src so a static value import fails lint instead of bundling or require()-ing the wrong copy.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e64427123
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve-from-project (
packages/vscode/AGENTS.md, adaptation #3) means extension source may only take types from@rslint/core,@rstest/core,rstackandjitiat compile time; the runtime modules are loaded from the user's project through explicit paths (the lint worker's--coredirectory, the rstest package lookup). Until now that was a convention only.This adds
@typescript-eslint/no-restricted-imports(allowTypeImports: true) overpackages/vscode/src/**/*.tsin the rootrstack.config.ts, so a static value import of any of those packages failspnpm lintwith a message pointing at the rule, whileimport typestays allowed. Dynamicimport(pathToFileURL(...))of project paths is unaffected. AGENTS.md notes the enforcement.Verified: the current tree passes (65 rules, 0 errors); a probe file with
import { CONFIG_DISCOVERY_PROTOCOL_VERSION } from '@rslint/core/config-loader'is reported andimport type { Reporter } from '@rstest/core'in the same file is not.Related Links
Checklist