fix(vscode): remove the legacy settings migration - #17
Merged
Conversation
Drop `migration.ts`, its tests, the `rstack.migrateSettings` command (manifest entry, palette registration and status-bar hover action) and the activation-time prompt with its `rstack.migration.dismissed` state. Pre-1.0 the extension owes no compatibility to earlier states, and the migration only served users of the two retired standalone extensions; keeping it meant every settings change carried a mapping-table update plus tests for a one-off flow, and the table already had to model dropped features (`rslint.binPath` / `customBinPath`, #14). The README keeps a one-paragraph note telling standalone-extension users to re-enter their settings under `rstack.*` and re-bind keybindings; AGENTS.md's namespace adaptation and pre-1.0 rule are reworded so no migration is implied. Closes #15
ADR 0001 and 0002 said the standalone Rstest extension's `rstest.nodeExecutable` "migrates to" `rstack.nodeExecutable`; the migration was removed in #15, so the parentheticals now state only that the legacy key had the same role.
fi3ework
changed the title
fi3ework
enabled auto-merge (squash)
August 18, 2026 07:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
What
Removes the settings migration from the retired standalone
rstack.rslint/rstack.rstestextensions:packages/vscode/src/migration.tsandtests/migration.test.tsdeleted (LEGACY_MAPPINGS, the planner, the prompt,PROMPT_DISMISSED_KEY).rstack.migrateSettingsdropped fromcontributes.commands, the shell's command registration and the status-bar hover (which now lists two shell actions; the row-count assertions and the hover comments follow).The activation-time prompt is gone from
ExtensionShell.activate().packages/vscode/AGENTS.md: adaptation ci: bump actions/upload-artifact to v7 for the Node 24 runtime #2 and the pre-1.0 rule no longer refer to a migration mapping;CONTEXT.md's Shell entry likewise.packages/vscode/README.md: the "Migrating from the standalone extensions" section is replaced by a one-paragraph "Coming from the standalone extensions" note — settings and keybindings are re-entered underrstack.*, andrslint.binPath/customBinPathpoint atrstack.rslint.corePathinstead. This resolves the issue's open question in favour of keeping the note.docs/adr/0001/0002: the parentheticals sayingrstest.nodeExecutable"migrates to"rstack.nodeExecutablenow say the legacy key had the same role and is not migrated — this repo keeps ADRs current (0001 was already amended by feat(vscode): format through rs fmt --lsp on the User Node runtime #12 and feat(vscode): lint through an editor-shipped worker and bridge define.lint() #14), so a stale mechanism description would conflict with the code.Verification
pnpm lint(rs lint --type-check): 0 errors, 0 type errors.pnpm test:unit: all passing.VSCODE_CLI=1 pnpm test:e2e vscode(shell/detection/fmt suites, covers the command registration and status bar): exit 0.rs fmt --check: clean.