chore: add bumpp and tag + GitHub Release to the release workflow - #20
Merged
Conversation
- `pnpm bump` (bumpp) bumps packages/vscode/package.json and commits `chore(vscode): release vX.Y.Z`; no tag, no push — the release workflow tags the commit it actually published from. - release.yml gains a final job that, after every target published, pushes the `vX.Y.Z` tag (idempotent) and creates the GitHub Release through changelogithub with notes from the conventional commits since the previous tag and the six VSIX files attached. Skipped on dry runs. - Document the flow in CONTRIBUTING.md and point to it from AGENTS.md.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac78060a15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… bump The first release lands through `pnpm bump` so main keeps an explicit `v0.1.0` bump commit.
Root scripts are pnpm -r fan-outs and must not reach into a package (AGENTS.md); bumpp and its config now live in packages/vscode and the root `bump` script is `pnpm -r run bump`. Verified the interactive prompt still gets a TTY through the fan-out for a single package.
- preflight job fails a non-dry dispatch from any ref but main (gh workflow run --ref accepts branches and tags); dry runs stay allowed anywhere. - The tag step is idempotent only when the existing tag points at this commit; a tag on another commit means the version was never bumped, and the run fails instead of attaching mismatched VSIX assets. - bumpp ^11.1.0 (engines >=20.19) instead of 12 (^22.18 || ^24.11 || >=26), matching the root Node floor of >=22.12.
All packages share one version (as in rspack-contrib/storybook-rsbuild), so bumpp lives at the root with files: packages/*/package.json and the VS Code manifest as the reference version. AGENTS.md records this as the one repo-level exception to the fan-out rule: no per-package script can bump several packages to the same version in one commit.
bumpp derives currentVersion from the globbed files, so reading packages/vscode/package.json to seed it was redundant and hard-coded a reference package the lockstep policy says does not exist. fetch-tags is dead config under fetch-depth: 0 (checkout takes the all-history refspec and never reads it), the event_name guard was tautological against a dispatch-only trigger, and the Report step, the ls -la and the banner comment were noise. Docs: CONTRIBUTING is the single place the release procedure is described.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tooling, modeled on rspack-contrib/storybook-rsbuild (`bumpp` for the version commit, `changelogithub` for the GitHub Release).
Changes
Version stays `0.1.0`; `main` remains the release candidate.
Verification