Conversation
fjson_object_from_fd() ignored the return value of printbuf_memappend(). If an append failed (e.g. out of memory) it went on to parse whatever had been accumulated so far, silently returning an object built from truncated input. Check the result and fail instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fjson_object_from_fd() ignored the return value of printbuf_memappend(). If an append failed (e.g. out of memory) it went on to parse whatever had been accumulated so far, silently returning an object built from truncated input. Check the result and fail instead.
Summary by cubic
Fixes
fjson_object_from_fd()so it no longer parses truncated input whenprintbuf_memappend()fails. Previously the return value was ignored, so on append failure (e.g., out of memory) it silently returned an object built from incomplete data; now it logs an error, frees the buffer, and returnsNULL.Written for commit eae5c6a. Summary will update on new commits.