Skip to content

Return the Promises waiter count for inspection #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −1
Open

Return the Promises waiter count for inspection #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0094f99
Return Promises waiter count for inspection
Aug 29, 2026
7a65eb5
Add waiter count regression coverage
OskarEichler Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/concurrent-ruby/concurrent/promises.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ def touched?
# For inspection.
# @!visibility private
def waiting_threads
@Waiters.each.to_a
@Waiters.value
end

# @!visibility private
Expand Down
13 changes: 13 additions & 0 deletions spec/concurrent/promises_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,19 @@ def behaves_as_delay(delay, value)
end

describe 'ResolvableEvent' do
specify "#waiting_threads" do
event = resolvable_event
expect(event.waiting_threads).to eq 0

waiter = Thread.new { event.wait }
Thread.pass until waiter.status == "sleep"

expect(event.waiting_threads).to eq 1
ensure
event&.resolve(false)
waiter&.join
end

specify "#wait" do
event = resolvable_event
expect(event.wait(0, false)).to be_falsey
Expand Down
Loading