Release TVar locks for all exceptions - #1116
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
bensheldon
reviewed
Aug 29, 2026
bensheldon
left a comment
bensheldon
left a comment
Contributor
There was a problem hiding this comment.
This looks ok.
It should be raise not raise e on the next line, right?
Are there other instances of this pattern we should update? Not necessarily jammed into this PR, but while it's top of mind, the help would be appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aborts the transaction before re-raising exceptions outside StandardError as well, preventing TVar locks from remaining held after Interrupt, SystemExit, or other Exception subclasses.
Verified by focused TVar specs and models; the review composite passes 2,796 examples with no failures.