Fix JRuby deprecation warnings in RubyDigest#131
Merged
olleolleolle merged 1 commit intoJun 18, 2026
Conversation
Replace deprecated JRuby API calls with their ThreadContext-aware equivalents introduced in JRuby 10. The pattern throughout is uniform: methods that previously resolved context internally now require an explicit ThreadContext argument. Also adds serialVersionUID fields to DigestClass and DigestBase, and marks the non-serializable MessageDigest field as transient.
|
For anyone else who might wonder: these methods were added in 10.0 so they are not available in 9.4... but 9.4 did not use a the gem for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated JRuby API calls with their ThreadContext-aware equivalents introduced in JRuby 10.
Methods that previously resolved context internally now require an explicit ThreadContext argument.
Also adds serialVersionUID fields to DigestClass and DigestBase, and marks the non-serializable MessageDigest field as transient.
This fixes the whole list of deprecation warnings.