Repository navigation
Limit the hexencode and bubblebabble results by RB_LEN_MAX - #157
Merged
Merged
Conversation
The result is a String, whose length can exceed LONG_MAX on mswin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Digest.hexencodeandDigest.bubblebabbleraise "digest string too long" when the result would exceedLONG_MAX. On mswinlongis 32 bits, so oncerb_len_tbecomes 64 bits there,Digest.hexencodestill rejects any input of 1GiB or more although the resulting String could hold it.This limits the results by
RB_LEN_MAXinstead, falling back toLONG_MAXon Ruby versions withoutHAVE_RB_LEN_T. Nothing changes whererb_len_tislong.Generated with Claude Code