Skip to content

Fix CGI::Util method definition locations in core.rbs #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 5 commits into from
Aug 2, 2026
+13 −7
Merged

Fix CGI::Util method definition locations in core.rbs #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3867e19
Remove nonexistent RFC822_DAYS/RFC822_MONTHS from CGI::Util
ksss Aug 2, 2026
9aa123a
Fix definition location of CGI escape-related methods
ksss Aug 2, 2026
13be357
Add missing h alias for CGI::Escape#escapeHTML
ksss Aug 2, 2026
5938399
Remove speculative rdoc-style comments on Escape/EscapeExt
ksss Aug 2, 2026
745bb49
Add reviewer
ksss Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions gems/cgi/0.5/core.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ class CGI

extend CGI::Util

include CGI::Escape

extend CGI::Escape

# <!--
# rdoc-file=lib/cgi/core.rb
# - CGI.new(tag_maker) { block }
Expand Down Expand Up @@ -886,7 +890,9 @@ class CGI
# # Sat, 01 Jan 2000 00:00:00 GMT
#
def rfc1123_date: (Time time) -> String
end

module Escape
def escape: (String) -> String
def unescape: (String, ?encoding: Encoding) -> String

Expand All @@ -899,6 +905,7 @@ class CGI
def unescapeHTML: (String) -> String
alias escape_html escapeHTML
alias unescape_html unescapeHTML
alias h escapeHTML

def escapeElement: (String, *String) -> String
| (String, Array[String]) -> String
Expand All @@ -907,15 +914,12 @@ class CGI
alias escape_element escapeElement
alias unescape_element unescapeElement

# Abbreviated day-of-week names specified by RFC 822
RFC822_DAYS: Array[String]

# Abbreviated month names specified by RFC 822
RFC822_MONTHS: Array[String]

# <!-- rdoc-file=lib/cgi/util.rb -->
# <!-- rdoc-file=lib/cgi/escape.rb -->
# The set of special characters and their escaped values
#
TABLE_FOR_ESCAPE_HTML__: Hash[String, String]
end

module EscapeExt
end
end
2 changes: 2 additions & 0 deletions gems/cgi/_reviewers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
reviewers:
- ksss