Implement FFI console mode support - #142
Merged
Merged
Conversation
Add the missing console mode API so JRuby and TruffleRuby match the native extension.
Ensure `rake test` exercises the checked-out FFI backend.
Make clean checkouts load the checked-out FFI implementation.
Contributor
|
Thank you @nobu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IO::ConsoleModefor the FFI backendIO#console_modeandIO#console_mode=LibCdefinitionsWhy
The native extension has supported console mode snapshots since 77ed8d5, but the FFI backend never implemented the equivalent API. JRuby and TruffleRuby therefore lacked
IO::ConsoleModebehavior.Closes #66.
Testing
test_console_mode: 1 test, 7 assertions, 0 failures, 0 errorstest_console_mode: 1 test, 7 assertions, 0 failures, 0 errorsgit diff --check