Prefer the registry over /etc/resolv.conf on native Windows - #153
Merged
Merged
Conversation
On native Windows `/etc/resolv.conf` resolves against the current drive, so a stray `etc\resolv.conf` at the drive root shadowed the DNS settings in the registry. Cygwin keeps reading the file first because its own resolver honors it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On native Windows,
Resolv::DNS::Config.default_config_hashchecks/etc/resolv.confbefore the registry. That path resolves against the current drive, so running from a drive that hasetc\resolv.confat its root makesResolv::DNSignore the DNS servers configured in Windows and use that file instead.This reads
Win32::Resolv.get_resolv_infofirst on mswin, MinGW and JRuby on Windows. Cygwin keeps the old order because its own resolver honors/etc/resolv.conf, and dropping it there would makeResolvdisagree withgetaddrinfo.I could not run the Cygwin branch of the new test locally.
Generated with Claude Code