fix: keep the url's query string when probing /json/version - #625
Merged
Conversation
route
force-pushed
the
fix/external-url-query
branch
2 times, most recently
from
September 1, 2026 17:32
3b92a7d to
e9daa69
Compare
`/json/version` was probed with the url's query string dropped, so an endpoint that authenticates with `?token=...` answered 401 and `:url` died with `undefined method 'host' for nil`.
route
force-pushed
the
fix/external-url-query
branch
from
September 1, 2026 17:49
e9daa69 to
4c522a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process#parse_json_versionbuilt the probe withURI.join(url, "/json/version"), which drops the query string. A browser reached through a proxy that authenticates with one —Ferrum::Browser.new(url: "http://chrome:3000?token=X")— therefore got a 401 HTML page,JSON::ParserErrorwas swallowed, andws_url=was handednil:The probe url is now built by rewriting only the scheme and path, keeping the query (and everything else) intact. Same path is used for
ws_url:, so a token on the websocket url survives too.Also: an endpoint that answers but yields no websocket url now raises
Ferrum::NoWebSocketUrlErrornaming the url, instead of theNoMethodErrorabove.Two system specs in
spec/browser_spec.rbput a token-authenticated proxy in front of a real external browser — one connects through it, one asserts the new error on a bad token. Both reproduce the reportedNoMethodErroronmain. Full suite: 609 examples, 0 failures.