Skip to content

fix(browser): let quit clean up a browser whose contexts were never built #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilMeyr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(browser): let quit clean up a browser whose contexts were never built #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ferrum/browser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def restart
def quit(wait: true)
return unless @client

contexts.close_connections
@contexts&.close_connections

@client.close
thread = @process.stop(wait: wait)
Expand Down
14 changes: 14 additions & 0 deletions spec/browser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,20 @@ def proxy_tunnel(socket, request, browser_url)
ensure
browser&.quit
end

it "recovers when a previous start died after the client was built" do
browser = Ferrum::Browser.new

allow(Ferrum::Contexts).to receive(:new).and_raise(Ferrum::DeadBrowserError)
expect { browser.restart }.to raise_error(Ferrum::DeadBrowserError)

allow(Ferrum::Contexts).to receive(:new).and_call_original

expect { browser.restart }.not_to raise_error
expect(browser.contexts).not_to be_nil
ensure
browser&.quit
end
end

describe "#resize" do
Expand Down
Loading