Make event start/end time optional with all-day rendering#1744
Closed
maebeale wants to merge 3 commits into
Closed
Make event start/end time optional with all-day rendering#1744maebeale wants to merge 3 commits into
maebeale wants to merge 3 commits into
Conversation
maebeale
marked this pull request as ready for review
June 18, 2026 18:05
maebeale
force-pushed
the
maebeale/event-time-fields-optional-styling
branch
from
June 18, 2026 20:13
7427f70 to
8a72aed
Compare
maebeale
changed the title
maebeale
force-pushed
the
maebeale/event-time-fields-optional-styling
branch
from
June 22, 2026 12:02
90d2df5 to
16b87b4
Compare
maebeale
changed the title
maebeale
changed the title
Time was required on the event form even though only the date matters for many events. Make the time inputs optional: a blank time persists as midnight and renders as all-day (no time shown) everywhere — show page, cards, mailers, tickets, and calendar exports (which now emit proper all-day entries). Style the optional fields (start/end time, registration close) grey instead of white, and add a hint explaining the all-day behavior and the midnight tradeoff. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/event-time-fields-optional-styling
branch
from
July 15, 2026 11:31
16b87b4 to
bbce24c
Compare
maebeale
changed the title
Keeps this PR scoped to the optional-time / all-day work. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
@jmilljr24 i'm going through all registration related PR's. is your vote to close this one or allow events to not require times? |
Collaborator
I would close it. More questions than answers, and has not been requested by the stakeholders. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
requiredfrom the start/end time inputs; a blank time persists as midnight and is treated as "no time" via a newEvent#all_day?.EventDecorator#times,ApplicationHelper#event_times_label, andcalendar_links(which now emits proper all-day calendar entries), so the show page, cards, tickets, mailers, and registration page all follow.UI Testing Checklist
Anything else to add?
🤖 Generated with Claude Code