Replace broken Log out link on static error pages with a Home link#5636
Open
awwaiid wants to merge 2 commits into
Open
Replace broken Log out link on static error pages with a Home link#5636awwaiid wants to merge 2 commits into
awwaiid wants to merge 2 commits into
Conversation
The static error pages (403/404/422/500) had a logout link relying on data-method="delete", which needs rails-ujs — JavaScript those static pages never load. Clicking it degraded to GET /users/sign_out, which has no route. Rather than adding a GET sign-out route (a logout-CSRF vector that link prefetchers can also trigger), this drops the logout button completely. Instead we'll look back to home/dashboard and as long as the whole app isn't crashed then they can log out from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static error pages (403/404/422/500) had a logout link relying on data-method="delete", which needs rails-ujs — JavaScript those static pages never load. Clicking it degraded to GET /users/sign_out, which has no route.
Rather than adding a GET sign-out route (a logout-CSRF vector that link prefetchers can also trigger), this drops the logout button completely. Instead we'll look back to home/dashboard and as long as the whole app isn't crashed then they can log out from there.
Implements #5101
Replaces #5189