Skip to content

docs: show wishlist labelling date in wishlist tables - #887

Merged
bari12 merged 4 commits into
rucio:mainfrom
bari12:patch-wishlist-date-column
Aug 27, 2026
Merged

docs: show wishlist labelling date in wishlist tables#887
bari12 merged 4 commits into
rucio:mainfrom
bari12:patch-wishlist-date-column

Conversation

@bari12

@bari12 bari12 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Assisted-by: Claude

@voetberg

Copy link
Copy Markdown
Contributor

Please fix the mypy error!


Run mypy --ignore-missing-imports .
tools/generate_wishlist.py:122: error: Missing return statement  [return]
Found 1 error in 1 file (checked 7 source files)
Error: Process completed with exit code 1.

bari12 added 2 commits August 26, 2026 17:50
mypy cannot prove that iterating itertools.count never completes, so
get_wishlisted_at was flagged with a missing return statement. Use the
same explicit while loop as get_component_labels instead.

Assisted-by: Claude
The wishlist page generation now requests the label events of every
closed wishlist issue, which exceeds the unauthenticated GitHub API
rate limit of 60 requests per hour. Pass GITHUB_TOKEN to the build
step, which generate_wishlist.py already picks up from the
environment, to use the authenticated rate limit instead.

Assisted-by: Claude
@bari12
bari12 merged commit 7797bd1 into rucio:main Aug 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants