fix(navigation-coloring-issue): Colouring of navigation tabs fix - #828
Open
pajka2T wants to merge 1 commit into
Open
fix(navigation-coloring-issue): Colouring of navigation tabs fix#828pajka2T wants to merge 1 commit into
pajka2T wants to merge 1 commit into
Conversation
pajka2T
force-pushed
the
navigation-colouring-fix
branch
from
September 2, 2026 12:44
4034e67 to
54a0976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #826
Work done
Subscriptions and Approve Rules buttons colour after clicking on them.
The problem with incorrect
pathnameis fixed by comparing url stored inmenuItemsdictionary not only with path got fromusePathname()Next.js function, but also with parameters of current url gained fromuseSearchParams()function. Values returned by these functions are concatenated and compared to stored value.It also works for children in dropdown menus - i.e. Approve Rules colours not only itself, but also its parent, the Rules tab.
Fix of the test checking navigation's work - included
useSearchParams()mock.