Skip to content

add interpreter node attribute and info - #81

Merged
fdevans merged 3 commits into
rundeck-plugins:mainfrom
dldrk:master
Aug 3, 2026
Merged

add interpreter node attribute and info#81
fdevans merged 3 commits into
rundeck-plugins:mainfrom
dldrk:master

Conversation

@dldrk

@dldrk dldrk commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

Adds a winrm-interpreter node attribute so the interpreter config (which Python binary/path to invoke) can be overridden per node, matching the pattern already used for authtype, winrmtransport, certpath, etc. Fixes rundeckpro#1452.


Maintainer notes:

  • Merged current main into this branch and resolved a conflict in plugin.yaml (the interpreter description text collided with feat: allow defining arbitrary python interpreter for newer distros #108's change of the default to python3).
  • The node-attribute override is only wired up for the two node-executing providers (NodeExecutor, FileCopier) — the WorkflowStep provider (WinRMCheck) takes hostname as a plain argument rather than running against a Rundeck-managed node, so a per-node override doesn't apply there. Corrected that provider's description text, which had been updated to claim node-level override support it doesn't actually have.
  • Verified locally (CI does not run on this PR): ./gradlew build passes and the full unit test suite (26 tests) passes.

@dldrk

dldrk commented Aug 24, 2021

Copy link
Copy Markdown
Contributor Author

@jsboak
jsboak requested a review from ltamaster July 21, 2023 18:23
# Conflicts:
#	plugin.yaml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Rundeck plugin metadata to expose the Python interpreter setting as a node-level override, making it possible to select a different interpreter per target node without changing the plugin instance configuration.

Changes:

  • Expands the interpreter config description to mention the node attribute override key (winrm-interpreter).
  • Adds renderingOptions.instance-scope-node-attribute: winrm-interpreter and groups the setting under an “Interpreter” UI group for both the NodeExecutor and FileCopier providers.

@fdevans
fdevans merged commit f4252fb into rundeck-plugins:main Aug 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants