Add OSRS FlipHub plugin

[zFallan121]

Adds OSRS FlipHub, a Grand Exchange flip tracker.

What it does

• Records GE offer history locally (buys/sells/completed/aborted)
• Shows per-flip and rolling profit/margins, GE buy-limit timers, and live OSRS Wiki prices
• Item bookmarks and price context in a side panel

Read-only / no automation

The plugin only observes GrandExchangeOfferChanged and related client events. It performs no automation and sends no input to the game. No RuneScape/Jagex credentials are requested, read, or transmitted.

Network / data handling (please note)

• Default (not linked): local-only. All trade data stays on the user's machine. The only network calls are read-only price lookups to the public OSRS Wiki price API (prices.runescape.wiki).
• Optional account link: if the user pastes a FlipHub license key in the plugin settings, their GE offer events (item, quantity, price, offer state, timestamps) are uploaded over HTTPS to FlipHub's servers (osrsfliphub.com) to power an online dashboard. This is opt-in - nothing is uploaded until the user links - and is disclosed both in the plugin description and in a dedicated config section. Clearing the key or clicking Unlink stops uploads immediately.

Source: https://github.com/zFallan121/OSRS-FlipHub-Plugin-Public
Licensed BSD 2-Clause.

[runelite-github-app]

New plugin osrs-fliphub: https://github.com/zFallan121/OSRS-FlipHub-Plugin-Public/tree/d9bb35dd5107da289cf1afd59441e3743b4b2910

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[riktenx]

Your plugin is too large. We have a limit on the autoreviewer of 200k tokens and you are at 290k.

only the main source code contributes to the token count. tests, resource files, and any comments in your source code are ignored.

As we do not have the capacity to review plugins of this size you will need to substantially reduce the size of your codebase if you want to get it merged. I am sure your LLM can help you with this.

some common issues:

• excess unused code
• verbose swing code that can be componentified/shrunk
• "data" expressed directly as java classes that could instead be loaded as json

[riktenx]

i took another glance at this and your codebase is sort of absurd, you have basically reimplemented an entire DI / hook / whatever system that was not necessary in the first place with this GeLifecyclePluginRuntimeFactoryContextFactory stuff, which itself appears to be the first layer of wrapping in like 7 layers of wrapping. you could probably eliminate 90% of your codebase by just using @Inject, your main source set has 48K LoC and i doubt there's more than like 5k of actual code there

[zFallan121]

i took another glance at this and your codebase is sort of absurd, you have basically reimplemented an entire DI / hook / whatever system that was not necessary in the first place with this GeLifecyclePluginRuntimeFactoryContextFactory stuff, which itself appears to be the first layer of wrapping in like 7 layers of wrapping. you could probably eliminate 90% of your codebase by just using @Inject, your main source set has 48K LoC and i doubt there's more than like 5k of actual code there

Thanks Riktenx, appreciate the quick feedback as always. I'll be back once I'm able to get this LoC down, I'll see if I can bring someone on to work with me atleast for some reviewing