Update pvp-performance-tracker to v1.8.2#13187
Open
Matsyir wants to merge 1 commit into
Open
Conversation
|
|
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Matsyir
force-pushed
the
pvp-performance-tracker1.8.2
branch
from
659abe8 to
17362ad
Compare
*Note: Currently live is 1.8.0, there is another PR for 1.8.1 (runelite#13143) Feel free to skip 1.8.1 and push 1.8.2 right away. But if it would be longer, there's a fairly significant visual issue in 1.8.0 that's been fixed in 1.8.1 1.8.1: ui fixes/clarifications - fixed filter bug where no fights would appear in your panel if the filter was empty, which is most of the time/default behavior. oops - improved filter sanitization - added new filter where you can search for >X attacks, and added tooltip to clarify filter functionality (1. RSN filter, 2. BorderStyle filter, 3. >X, <X, >=X, <=X total attacks from the client player) - moved death icon (red skull) to minimize text & flag clipping/overlapping. Not sure how i like this location but it's an improvement 1.8.2: - Improved filter behavior - Improved overall performance & responsiveness - various UI threading optimizations. It feels much smoother & snappier overall. From me & LogicalSolution's testing, there doesn't seem to be any issues, but this includes some of those potentially problematic race-condition-causing threading changes - Customizable UI ~ New config options for: hide panel BG images, center vs. side-align text, and customize nearly all colors, including a dropdown for preset color styles/configurations. - Adjusted death icon (red skull) placement +1 amended commit for another fix I forgot to include, one of the primary tooltips was broken +2 amended commit for another fix related to pvp-hub syncing by LogicalSolutions
Matsyir
force-pushed
the
pvp-performance-tracker1.8.2
branch
from
17362ad to
d3eb2c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Note: Currently live is(thanks for merging it fairly quickly 😄)v1.8.0, there is another PR forv1.8.1(#13143)Feel free to skip
v1.8.1and pushv1.8.2right away.But if it would be longer, there's a fairly significant visual issue in
v1.8.0that's been fixed inv1.8.1, so it wouldn't hurt to have that merged ASAP.1.8.2:
Preview of new color presets, configs, and various other UI adjustments:
A confirmation popup appears when selecting a color preset config, to clarify that the config UI doesn't visually update when we change these configs and internally apply the newly selected color preset:
Many thanks once again to @LogicalSoIutions for helping with many of the fixes involved here, testing, as well as Pan1c + Lagunarium for constantly testing and giving valuable feedback :)
Thanks to @Sacca-1 who also made a PR for the 1.8.0->1.8.1 fix, although I took @LogicalSoIutions' since it had a smaller diff.
*edit: I force-pushed another commit about 1hr after opening this PR, there was simply a broken tooltip I forgot to fix initially. Should be fine for all the core behaviors
edit2: Force-pushed a 2nd commit, new fix by LogicalSolutions. There was a bug where clients keep retrying a failed network request every 60s on loop. Matsyir/pvp-performance-tracker#94