update osrs-tcg#13208
Open
Azderi wants to merge 2 commits into
Open
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Member
|
don't read/write files outside of your plugin-specific subfolder within .runelite, it looks like this stuff you added is for debugging purposes. you can either add a separate debug plugin in the test source set (which won't ship with your plugin and won't get looked at but you can use it during development) or just remove it the sailing plugin has an example of a debug plugin if you want to look there, they can be pretty handy |
riktenx
added
the
waiting for author
Removed the debug features left in the code for editing catalog info
runelite-github-app
Bot
removed
the
waiting for author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection album updates, Dink and webhook integration